Spaces should not be used on either side of an m dash. Period.

I shake my head at the misguided calls to abolish the m dash. Correct grammar promotes clarity of thought and communication, and the m dash serves that goal admirably. Disapproval of its use doesn't make one sound efficient, but the opposite.